search

solidusio / solidus_avatax

Avatax integration with Solidus
BSD 3-Clause "New" or "Revised" License
5 stars 23 forks source link

loosen the dependency on solidus_core #12

Closed peterberkenbosch closed 8 years ago

peterberkenbosch commented 8 years ago

gemspec specified 1.1.0.pre while master is on 1.2.0.alpha

jordan-brough commented 8 years ago

@peterberkenbosch thanks for letting us know about this!

Removing the dependency entirely doesn't seem quite right. E.g. I think (but am not sure) that this version won't work with v1.0 of Solidus.

@solidusio/owners - thoughts on how to manage versions here? I believe the current code could be as loose as >= 1.1.0.pre if we wanted. Since Bonobos is using and maintaining this gem it's likely that it will stay current with Solidus master branch. Thoughts though?

peterberkenbosch commented 8 years ago

@jordan-brough for the v1.0 one could use the v1.0 branch here. Could mimic the version currently on master though.

jordan-brough commented 8 years ago

@peterberkenbosch I tweaked your change to limit us to <= 1.2.x and merged it. @solidusio/owners let me know if anyone thinks we should approach versioning differently. I have no strong preference here.

jordan-brough commented 8 years ago

And thanks @peterberkenbosch!