search

solidusio / solidus_avatax

Avatax integration with Solidus
BSD 3-Clause "New" or "Revised" License
5 stars 23 forks source link

Update adjustment validation to check source_type, not source #4

Closed philbirt closed 9 years ago

philbirt commented 9 years ago

This validation doesn't work as expected currently.

magnusvk commented 9 years ago

I'll channel my inner @jhawthorn here and ask for a failing spec. :)

jordan-brough commented 9 years ago

@magnusvk I actually told @philbirt I'd add one as penance for writing this broken code in the first place without a spec. :)

magnusvk commented 9 years ago

Hah; that works for me. :)

jordan-brough commented 9 years ago

@magnusvk @philbirt added a spec.

philbirt commented 9 years ago

Looks good to me :+1: