search

solidusio / solidus_avatax

Avatax integration with Solidus
BSD 3-Clause "New" or "Revised" License
5 stars 23 forks source link

Rename "generate" methods #7

Closed jordan-brough closed 6 years ago

jordan-brough commented 9 years ago

See discussion here.

It's surprising that SpreeAvatax::SalesInvoice.generate(order) modifies the order, rather than just creating an invoice. Something like SpreeAvatax::SalesInvoice.calculate_and_set_taxes(order) would probably be a better name.

There are at least three generate methods defined in solidus_avatax right now. We'd probably want to update all of them and deprecate the generate name.

gmacdougall commented 9 years ago

Thanks for filing an issue for this.