search

solidusio / solidus_avatax

Avatax integration with Solidus
BSD 3-Clause "New" or "Revised" License
5 stars 23 forks source link

Update solidus_avatax for Solidus >= 1.1.0 #8

Closed jordan-brough closed 9 years ago

jordan-brough commented 9 years ago

A couple things that need to be brought up to date here for Solidus >= 1.1.0

1) spree_adjustments.state has been moved to spree_adjustments.finalized

See https://github.com/solidusio/solidus/pull/279

We could alternatively replace the direct-table-accesses (e.g. update_all) so that they don't blow up, and we could have a bunch of checks scattered around to decide whether to set state or finalized (to avoid blowing up in the old code and avoid generating deprecation warnings all the time in the new Solidus) but that didn't seem worth it in this case. Happy to hear other opinions though.

2) Spree::Address is now immutable

The address_decorator logic is now useless and the specs are also failing when they try to mutate an address

3) Confirm is now truly a required step.

Some specs that try to transition from payment -> complete are failing.

athal7 commented 9 years ago

:+1:

magnusvk commented 9 years ago

:+1: