solidusio / solidus_braintree

πŸ’³ Integrate Solidus with Braintree
https://www.braintreepayments.com/
BSD 3-Clause "New" or "Revised" License
19 stars 55 forks source link

Add Response to log entry permitted classes #109

Closed gsmendoza closed 1 year ago

gsmendoza commented 1 year ago

Summary

Fixes https://github.com/solidusio/solidus_braintree/issues/108.

SolidusBraintree::Response is a direct subclass of ActiveMerchant::Billing::Response, which is a core permitted class of Spree:LogEntry(1). Furthermore, SolidusBraintree::Response doesn't have any additional attributes. Thus, it should be safe to log.

As recommended by the Spree::LogEntry::DisallowedClass error message (2), we're adding SolidusBraintree::Response to log_entry_permitted_classes through an initializer.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed: