solidusio / solidus_braintree

💳 Integrate Solidus with Braintree
https://www.braintreepayments.com/
BSD 3-Clause "New" or "Revised" License
19 stars 55 forks source link

Update SolidusBraintree InstallGenerator to install frontend code #112

Closed gsmendoza closed 1 year ago

gsmendoza commented 1 year ago

Summary

We want the SolidusBraintree InstallGenerator to install the frontend code so that users can customize it easily.

Closes https://github.com/solidusio/solidus_braintree/issues/104.

Known concern: SolidusBraintree 2.0 is blocked by Solidus 3.4

We've updated SolidusBraintree to be compatible with the edge Solidus and SolidusStarterFrontend versions. As a result, the present SolidusBraintree would require Solidus and SolidusStarterFrontend 3.4.0. Thus, we can only release SolidusBraintree 2.0 once Solidus 3.4.0 is released.

If we want SolidusBraintree 2.0 to be compatible with the latest stable version of Solidus (3.3.1), we can create a separate branch of this repo targetting that Solidus version. We'll then release SolidusBraintree 2.0.0 from that branch.

Testing

I was able to successfully update a Rails app with solidus_paypal_braintree to this new version of SolidusBraintree. See https://github.com/gsmendoza/solidus_store/tree/rails-7-0-4--solidus-3-4-0-dev--braintree--renamed.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

gsmendoza commented 1 year ago

What about enforcing the solidus 3.4 dependency in the gemspec?

@kennyadsl I'll go first with @elia's suggestion of backporting the view changes in Solidus master to Solidus 3.3. Hopefully, this PR will work with Solidus v3.3 by then.