Add device data collection - Githubissues

solidusio / solidus_braintree

💳 Integrate Solidus with Braintree

https://www.braintreepayments.com/

BSD 3-Clause "New" or "Revised" License

19 stars 55 forks source link

Add device data collection #116

Closed gsmendoza closed 1 year ago

gsmendoza commented 1 year ago

Closes https://github.com/solidusio/solidus_braintree/issues/115.

Revision of https://github.com/solidusio/solidus_braintree/pull/103.

This commit adds device data collection.

See: https://developer.paypal.com/braintree/docs/guides/premium-fraud-management-tools/device-data-collection

Testing

Confirmed after checking out with Braintree Credit Card payment method:

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

[x] I have written a thorough PR description.
[x] I have kept my commits small and atomic.
[x] I have used clear, explanatory commit messages.

The following are not always needed:

📖 I have updated the README to account for my changes.
📑 I have documented new code with YARD.
🛣️ I have opened a PR to update the guides.
✅ I have added automated tests to cover my changes.
📸 I have attached screenshots to demo visual changes.

gsmendoza commented 1 year ago

@SyborgStudios I made the following minor changes to your PR:

Removed IS_FRONTEND.
Fixed lint errors.

Can you review?

gsmendoza commented 1 year ago

@SyborgStudios I'm merging this now :)