Migrate database by default - Githubissues

solidusio / solidus_braintree

💳 Integrate Solidus with Braintree

https://www.braintreepayments.com/

BSD 3-Clause "New" or "Revised" License

19 stars 55 forks source link

Migrate database by default #117

Closed gsmendoza closed 1 year ago

gsmendoza commented 1 year ago

We need to migrate the database by default so that once we add Braintree to the Solidus installer, running solidus:install would automatically run the SolidusBraintree migrations. See https://github.com/solidusio/solidus/issues/4749.

This should be safe since migrate is also enabled by default in SolidusPaypalCommercePlatform. See https://github.com/solidusio/solidus_paypal_commerce_platform/blob/a6f87f5d6a1621eda453db31ccdc8c3903ef48c4/lib/generators/solidus_paypal_commerce_platform/install/install_generator.rb#L6.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

[x] I have written a thorough PR description.
[x] I have kept my commits small and atomic.
[x] I have used clear, explanatory commit messages.

The following are not always needed:

📖 I have updated the README to account for my changes.
📑 I have documented new code with YARD.
🛣️ I have opened a PR to update the guides.
✅ I have added automated tests to cover my changes.
📸 I have attached screenshots to demo visual changes.