Backport SolidusPaypalBraintree rename and earlier changes to v1.x - Githubissues

solidusio / solidus_braintree

💳 Integrate Solidus with Braintree

https://www.braintreepayments.com/

BSD 3-Clause "New" or "Revised" License

19 stars 55 forks source link

Backport SolidusPaypalBraintree rename and earlier changes to v1.x #128

Closed gsmendoza closed 1 year ago

gsmendoza commented 1 year ago

Summary

Closes https://github.com/solidusio/solidus_braintree/issues/127.

This PR would fast-forward https://github.com/solidusio/solidus_braintree/tree/v1.x up to and before https://github.com/solidusio/solidus_braintree/pull/102. (To fix the CI, I cherry-picked the RuboCop offense fixes cb82bfe0ccbd098893cefb4a182560c82007bb64 and 838c0251c4def46c5b50cca587bbc0a0bef8fee6.)

This is in preparation for releasing the last 1.x version for SolidusBraintree: v1.3.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

[x] I have written a thorough PR description.
[x] I have kept my commits small and atomic.
[x] I have used clear, explanatory commit messages.

The following are not always needed:

📖 I have updated the README to account for my changes.
📑 I have documented new code with YARD.
🛣️ I have opened a PR to update the guides.
✅ I have added automated tests to cover my changes.
📸 I have attached screenshots to demo visual changes.

gsmendoza commented 1 year ago

Closing. As discussed offline, we don't want to include the name change in the 1.x line of the extension since it's a major breaking change.