Backport HostedForm device data collection to v2.x - Githubissues

solidusio / solidus_braintree

💳 Integrate Solidus with Braintree

https://www.braintreepayments.com/

BSD 3-Clause "New" or "Revised" License

19 stars 55 forks source link

Backport HostedForm device data collection to v2.x #135

Closed gsmendoza closed 1 year ago

gsmendoza commented 1 year ago

Summary

Closes https://github.com/solidusio/solidus_braintree/issues/132.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

[x] I have written a thorough PR description.
[x] I have kept my commits small and atomic.
[x] I have used clear, explanatory commit messages.

The following are not always needed:

📖 I have updated the README to account for my changes.
📑 I have documented new code with YARD.
🛣️ I have opened a PR to update the guides.
✅ I have added automated tests to cover my changes.
📸 I have attached screenshots to demo visual changes.

gsmendoza commented 1 year ago

@kennyadsl Makes sense. Plus, I think it would be ideal if we sort out the remaining concerns with device data (compatibility with other payment methods, reuse with saved payment sources) before we backport it to 2.0x. I'm closing this for now. We can reopen it once we're ready.