use rubocop-rspec 2.x - Githubissues

solidusio / solidus_dev_support

A collection of tools for developing Solidus extensions.

MIT License

21 stars 27 forks source link

use rubocop-rspec 2.x #161

Closed ccarruitero closed 3 years ago

ccarruitero commented 3 years ago

Summary

Running rubocop with current solidus_dev_support version throws an error.

The problem is that rubocop-rspec 1.x is not compatible with rubocop 1.0

Updating rubocop-rspec to 2.0. solve the problem

Checklist

[ ] I have structured the commits for clarity and conciseness.
[ ] I have added relevant automated tests for this change.

mergify[bot] commented 3 years ago

It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:

bug for bugfixes.
enhancement for new features and improvements.
documentation for documentation changes.
security for security patches.
removed for feature removals.
infrastructure for internal changes that should not go in the changelog.

Additionally, the maintainer may also want to add one of the following:

breaking for breaking changes.
deprecated for feature deprecations.

Once the correct labels have been set, simply remove the needs changelog label label from this PR so I can merge it.