solidusio / solidus_dev_support

A collection of tools for developing Solidus extensions.
MIT License
21 stars 27 forks source link

Do not raise if source_code_uri is missing in the gemspec #163

Closed kennyadsl closed 3 years ago

kennyadsl commented 3 years ago

Summary

That metadata is useful to automatically generate the CHANGELOG based on GitHub activity, using Oktokit and github_changelog_generator.

But a lot of extensions do not have that metadata set. We can be more kind by not making specs ran with rake (which are unrelated) fail when that information is missing.

This is the output when that metadata is missing after this PR will be merged:

$ bundle exec rake
It won't be possible to automatically generate the CHANGELOG for this extension because the
gemspec is missing the `source_code_uri` metadata. Please add this line to the gemspec to
enable automatic CHANGELOG generation:

    s.metadata["source_code_uri"] = 'https://github.com/org/repo'

Refs:

Checklist

mergify[bot] commented 3 years ago

It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:

Additionally, the maintainer may also want to add one of the following:

Once the correct labels have been set, simply remove the needs changelog label label from this PR so I can merge it.