Move factories to their new location when updating extensions

solidusio / solidus_dev_support

A collection of tools for developing Solidus extensions.

MIT License

21 stars 27 forks source link

Move factories to their new location when updating extensions #173

Closed kennyadsl closed 1 year ago

kennyadsl commented 3 years ago

Summary

Factories should be placed into a specific folder to be correctly loaded by the SolidusDevSupport::TestingSupport::Factories.load_for() method. Although it works even with the legacy path (emitting a deprecation warning), this automated step could help us migrating extensions with time.

This PR is a draft because there are some issues testing the code, I will revisit this later, hopefully with someone that has more experience with these specs.

Checklist

[ ] I have structured the commits for clarity and conciseness.
[ ] I have added relevant automated tests for this change.

mergify[bot] commented 3 years ago

It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:

bug for bugfixes.
enhancement for new features and improvements.
documentation for documentation changes.
security for security patches.
removed for feature removals.
infrastructure for internal changes that should not go in the changelog.

Additionally, the maintainer may also want to add one of the following:

breaking for breaking changes.
deprecated for feature deprecations.

Once the correct labels have been set, simply remove the needs changelog label label from this PR so I can merge it.

stale[bot] commented 1 year ago

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

stale[bot] commented 1 year ago

Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you!