Unify sandbox creation source

solidusio / solidus_dev_support

A collection of tools for developing Solidus extensions.

MIT License

21 stars 27 forks source link

Unify sandbox creation source #182

Closed Naokimi closed 2 years ago

Naokimi commented 2 years ago

Summary

The sandbox apps for solidus and solidus' extensions have different code leading to different creation outcomes. For example solidus' sandbox has a docker-compose development environment, but solidus extension's sandbox doesn't.

This PR fixes the discrepancies by creating a new repo with a bash script on it, which can be called to create the sandbox app. Since future updates will be made at a single point, this will ensure alignment.

Once the PR is approved I will transfer ownership of the bash script to Solidus and modify the PR to point to the correct URL before merging.

Related PRs:

https://github.com/solidusio/solidus/pull/4343

Checklist

[x] I have structured the commits for clarity and conciseness.
[x] I have added relevant automated tests for this change.

mergify[bot] commented 2 years ago

It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:

bug for bugfixes.
enhancement for new features and improvements.
documentation for documentation changes.
security for security patches.
removed for feature removals.
infrastructure for internal changes that should not go in the changelog.

Additionally, the maintainer may also want to add one of the following:

breaking for breaking changes.
deprecated for feature deprecations.

Once the correct labels have been set, simply remove the needs changelog label label from this PR so I can merge it.

kennyadsl commented 2 years ago

As mentioned in https://github.com/solidusio/solidus/pull/4343, we have some plans for extensions and it's not the right moment to change this, thanks again!