Closed nvandoorn closed 2 years ago
It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:
bug
for bugfixes.enhancement
for new features and improvements.documentation
for documentation changes.security
for security patches.removed
for feature removals.infrastructure
for internal changes that should not go in the changelog.Additionally, the maintainer may also want to add one of the following:
breaking
for breaking changes.deprecated
for feature deprecations.Once the correct labels have been set, simply remove the needs changelog label
label from this PR so I can merge it.
@nvandoorn I created this branch based on your PR to test the suggestions I made here. As of the moment, I'm still waiting for the build to complete. Tomorrow, I'll test the branch againts the SolidusAuthDevise specs.
Hi @nvandoorn ! I have just submitted a separate PR that uses Capybara::Driver#resize_window_to (see https://github.com/solidusio/solidus_dev_support/pull/183#discussion_r880236011). Appreciate if you can check it out! Thanks!
@nvandoorn Thank you for this PR. We're closing this PR since https://github.com/solidusio/solidus_dev_support/pull/184 has already been merged.
Hey @gsmendoza, thanks for keeping this moving! I was on vacation last week so it's great to see this got resolved.
Summary
After updating to
cimg/ruby:2.7-browsers
, we have a newer version of Selenium running on CircleCI. As such, we need to define our configuration in a way that is compatible with the new version.This change is based on the example configuration provided here: https://github.com/teamcapybara/capybara/blob/master/spec/selenium_spec_chrome.rb
Checklist