Closed gsmendoza closed 2 years ago
It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:
bug
for bugfixes.enhancement
for new features and improvements.documentation
for documentation changes.security
for security patches.removed
for feature removals.infrastructure
for internal changes that should not go in the changelog.Additionally, the maintainer may also want to add one of the following:
breaking
for breaking changes.deprecated
for feature deprecations.Once the correct labels have been set, simply remove the needs changelog label
label from this PR so I can merge it.
Steps to reproduce
Run
bundle exec rspec
in SolidusAuthDevise.Expected behavior
Specs should pass.
Actual behavior
Getting errors like this:
See https://app.circleci.com/pipelines/github/solidusio/solidus_auth_devise/338/workflows/ae0447ab-543d-47a6-8e72-be8afb94be4d/jobs/1356.
Tests to confirm
I tested this SolidusDevSupport branch against SolidusAuthDevise. See:
Related PRs
This was based on https://github.com/solidusio/solidus_dev_support/pull/183.
Checklist