solidusio / solidus_dev_support

A collection of tools for developing Solidus extensions.
MIT License
21 stars 27 forks source link

Fix window resizing of `solidus_chrome_headless` driver #184

Closed gsmendoza closed 2 years ago

gsmendoza commented 2 years ago

Steps to reproduce

Run bundle exec rspec in SolidusAuthDevise.

Expected behavior

Specs should pass.

Actual behavior

Getting errors like this:

Failures:

  1) Checkout leaving and returning to address step
     Got 0 failures and 2 other errors:

     1.1) Failure/Error: visit spree.root_path

          NoMethodError:
            undefined method `args' for nil:NilClass
          # ./spec/features/checkout_spec.rb:25:in `block (2 levels) in <top (required)>'
          # ./spec/support/confirm_helpers.rb:14:in `block (2 levels) in <top (required)>'

See https://app.circleci.com/pipelines/github/solidusio/solidus_auth_devise/338/workflows/ae0447ab-543d-47a6-8e72-be8afb94be4d/jobs/1356.

Tests to confirm

I tested this SolidusDevSupport branch against SolidusAuthDevise. See:

Related PRs

This was based on https://github.com/solidusio/solidus_dev_support/pull/183.

Checklist

mergify[bot] commented 2 years ago

It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:

Additionally, the maintainer may also want to add one of the following:

Once the correct labels have been set, simply remove the needs changelog label label from this PR so I can merge it.