Closed waiting-for-dev closed 1 year ago
It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:
bug
for bugfixes.enhancement
for new features and improvements.documentation
for documentation changes.security
for security patches.removed
for feature removals.infrastructure
for internal changes that should not go in the changelog.Additionally, the maintainer may also want to add one of the following:
breaking
for breaking changes.deprecated
for feature deprecations.Once the correct labels have been set, simply remove the needs changelog label
label from this PR so I can merge it.
Summary
We were storing the Slack secrets on a CircleCI context. Although we were also passing them to forks, it resulted on unauthorized builds for external contributions.
We could work around the issue in two ways:
CIRCLECI_USERNAME
orCIRCLE_PR_USERNAME
env vars are in a list of allowed users. However, that would be something difficult to maintain, and there's no other way to check the user's role.Given that we don't find those trade-offs to be acceptable, we remove the integration for now.
Closes #4902
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: