solidusio / solidus_dev_support

A collection of tools for developing Solidus extensions.
MIT License
21 stars 27 forks source link

Remove Slack notifications for CI failures #199

Closed waiting-for-dev closed 1 year ago

waiting-for-dev commented 1 year ago

Summary

We were storing the Slack secrets on a CircleCI context. Although we were also passing them to forks, it resulted on unauthorized builds for external contributions.

We could work around the issue in two ways:

Given that we don't find those trade-offs to be acceptable, we remove the integration for now.

Closes #4902

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

mergify[bot] commented 1 year ago

It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:

Additionally, the maintainer may also want to add one of the following:

Once the correct labels have been set, simply remove the needs changelog label label from this PR so I can merge it.