Closed waiting-for-dev closed 1 year ago
It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:
bug
for bugfixes.enhancement
for new features and improvements.documentation
for documentation changes.security
for security patches.removed
for feature removals.infrastructure
for internal changes that should not go in the changelog.Additionally, the maintainer may also want to add one of the following:
breaking
for breaking changes.deprecated
for feature deprecations.Once the correct labels have been set, simply remove the needs changelog label
label from this PR so I can merge it.
@kennyadsl Any reason we can't merge this so we can get tests running at least against older versions of Solidus and work on getting tests passing against ~master~ main in a separate PR?
I think we can move this forward now @waiting-for-dev, isn't it?
Done! Please, let us know if there's any problem.
Summary
Stop trying to pull solidus_frontend v4, which doesn't exist.
Adopt new Solidus default branch. Ref. https://github.com/solidusio/solidus/pull/5042
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: