Allow loading of factories from namespaced extensions

solidusio / solidus_dev_support

A collection of tools for developing Solidus extensions.

MIT License

21 stars 27 forks source link

Allow loading of factories from namespaced extensions #207

Closed forkata closed 1 year ago

forkata commented 1 year ago

Summary

The previous glob did not allow there to be more than one level of namespacing in the extension file structure when loading factories. This change will support extensions that have their factories in a folder structure like lib/super_good/solidus_taxjar/testing_support/factories/*.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

[x] I have written a thorough PR description.
[x] I have kept my commits small and atomic.
[x] I have used clear, explanatory commit messages.

The following are not always needed:

📖 I have updated the README to account for my changes.
📑 I have documented new code with YARD.
🛣️ I have opened a PR to update the guides.
✅ I have added automated tests to cover my changes.
📸 I have attached screenshots to demo visual changes.

mergify[bot] commented 1 year ago

It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:

bug for bugfixes.
enhancement for new features and improvements.
documentation for documentation changes.
security for security patches.
removed for feature removals.
infrastructure for internal changes that should not go in the changelog.

Additionally, the maintainer may also want to add one of the following:

breaking for breaking changes.
deprecated for feature deprecations.

Once the correct labels have been set, simply remove the needs changelog label label from this PR so I can merge it.

forkata commented 1 year ago

This has to be rebased on #204 for tests to run, but that branch is currently failing CI.

elia commented 1 year ago

Thanks, good catch!