solidusio / solidus_dev_support

A collection of tools for developing Solidus extensions.
MIT License
21 stars 27 forks source link

Switch to main branch #211

Closed mamhoff closed 1 year ago

mamhoff commented 1 year ago

Summary

This changes all references to the master branch in the repository to main in anticipation of changing the default branch on the repo to main.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

mergify[bot] commented 1 year ago

It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:

Additionally, the maintainer may also want to add one of the following:

Once the correct labels have been set, simply remove the needs changelog label label from this PR so I can merge it.

kennyadsl commented 1 year ago

Thanks @mamhoff. Does this mean that by merging this PR we will need to change the default branch of all extensions (to keep them aligned with the default template)? I'm a bit scared about the work needed for that.

On the other side, if you create an extension today using the template, it will create it with the wrong default branch name.

@solidusio/core-team @solidusio/nebulab any thoughts?

mamhoff commented 1 year ago

Most of this affects only new extensions as far as I can oversee: gemspec, README and so on. The only change I'm not so sure about what it does is the mergify one, but I don't imagine that the mergify.yml in this repo would affect any other repo?

kennyadsl commented 1 year ago

When you execute the task again on an existing extension, it will keep asking to update those pieces over and over again. Not a big deal though, as you mentioned, it will only in places that you probably don't want to update anyway.

kennyadsl commented 1 year ago

For mergify: I think you are right, it doesn't impact any other repo, but merging this PR we should change the default branch here to have it working.

waiting-for-dev commented 1 year ago

I think that renaming master to main for all the supported extensions (the ones in solidusio) is very straightforward: doing the rename and creating very minor (and probably mostly cosmetic because of the automatic redirects). So I'd merge this PR once that's being done. What do you think?

waiting-for-dev commented 1 year ago

I renamed the branch accordingly.

waiting-for-dev commented 1 year ago

All not-archived extensions on the solidusio organization are now using main as the default branch name.