solidusio / solidus_dev_support

A collection of tools for developing Solidus extensions.
MIT License
21 stars 27 forks source link

Remove dependency on the webdrivers gem #213

Closed jarednorman closed 11 months ago

jarednorman commented 1 year ago

Summary

The webdrivers gem no longer works with recent versions of Chrome. Recent versions of selenium-webdriver (newer than 4.11) achieve the same effect.

One caveat with this change: it implicitly requires Ruby 3 as that's the requirement for selenium-webdriver 4.11+.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

mergify[bot] commented 1 year ago

It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:

Additionally, the maintainer may also want to add one of the following:

Once the correct labels have been set, simply remove the needs changelog label label from this PR so I can merge it.

benjaminwil commented 11 months ago

@jarednorman If you rebase this against main the solidus-older CI job should be okay now.

jarednorman commented 11 months ago

Thanks, done.