Allow Puma 6 - Githubissues

solidusio / solidus_dev_support

A collection of tools for developing Solidus extensions.

MIT License

21 stars 27 forks source link

Allow Puma 6 #216

Closed mamhoff closed 8 months ago

mamhoff commented 8 months ago

Summary

Puma 6 was disallowed in 2022, because back then Rails itself generated Gemfiles with `'puma', "< 6". This is not the case anymore, in fact, Rails comes with Rack 3 which instead is incompatible with Puma 5.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

[x] I have written a thorough PR description.
[x] I have kept my commits small and atomic.
[x] I have used clear, explanatory commit messages.

mergify[bot] commented 8 months ago

It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:

bug for bugfixes.
enhancement for new features and improvements.
documentation for documentation changes.
security for security patches.
removed for feature removals.
infrastructure for internal changes that should not go in the changelog.

Additionally, the maintainer may also want to add one of the following:

breaking for breaking changes.
deprecated for feature deprecations.

Once the correct labels have been set, simply remove the needs changelog label label from this PR so I can merge it.