Allow rspec-rails 6 - Githubissues

solidusio / solidus_dev_support

A collection of tools for developing Solidus extensions.

MIT License

21 stars 27 forks source link

Allow rspec-rails 6 #217

Closed mamhoff closed 7 months ago

mamhoff commented 7 months ago

Summary

rspec-rails < 6.0.2 is incompatible with Rails 7.1 because of stricter view path typecasting in Rails 7.1. This bug is fixed in rspec-rails 6.0.2. Without this, controller specs in extensions will break.

https://github.com/rspec/rspec-rails/pull/2631

Checklist

The following are mandatory for all PRs:

[x] I have written a thorough PR description.
[x] I have kept my commits small and atomic.
[x] I have used clear, explanatory commit messages.

mergify[bot] commented 7 months ago

It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:

bug for bugfixes.
enhancement for new features and improvements.
documentation for documentation changes.
security for security patches.
removed for feature removals.
infrastructure for internal changes that should not go in the changelog.

Additionally, the maintainer may also want to add one of the following:

breaking for breaking changes.
deprecated for feature deprecations.

Once the correct labels have been set, simply remove the needs changelog label label from this PR so I can merge it.