Add `rspec-retry` dependency - Githubissues

solidusio / solidus_dev_support

A collection of tools for developing Solidus extensions.

MIT License

21 stars 27 forks source link

Add `rspec-retry` dependency #218

Open mamhoff opened 2 months ago

mamhoff commented 2 months ago

Solidus core defines a spec helper module spree/testing_support/flaky which relies on rspec-retry. When using this from other gems, these gems have to know to require rspec-retry, even though they already have solidus_dev_support. I think it would be a good idea to just add it here instead of as a dev dependency on every extension that might have flaky specs.

mergify[bot] commented 2 months ago

It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:

bug for bugfixes.
enhancement for new features and improvements.
documentation for documentation changes.
security for security patches.
removed for feature removals.
infrastructure for internal changes that should not go in the changelog.

Additionally, the maintainer may also want to add one of the following:

breaking for breaking changes.
deprecated for feature deprecations.

Once the correct labels have been set, simply remove the needs changelog label label from this PR so I can merge it.