Fork `solidus_frontend` into a separate repo

gsmendoza commented 2 years ago

Dependencies

Dependent on #2.

Wasn't able to update yet:

[x] Test on CircleCI - realized only now that I can probably test the repo on my gsmendoza CircleCI account.
[x] Rebuild SolidusLegacyFrontend as a Solidus extension.
[x] Instead of pointing SolidusLegacyFrontend to Solidus, point the gem to Solidus' subprojects instead (excluding SolidusFrontend, of course).
No longer applicable - Test if renaming the manifest.js will break production apps depending on SolidusFrontend.
[x] Update Gemfile - Remove :frontend group.
[x] Update README
- Add notice to let new users know that this is not the recommended frontend anymore.
- Rename "Testing" to "Contributing".
[x] Update Gem summary - We could also link to the new recommended starter frontend.
[x] Test if solidus frontend can be added to an app AFTER Solidus has been installed on it (without any frontend).
[x] Ensure that SolidusFrontend will allow backward compatibility for Solidus starting with 3.2.0.alpha.

[x] ./.circleci
[x] ./.dockerdev
- [x] ./.dockerdev/.psqlrc
- [x] ./.dockerdev/Dockerfile
- Got docker-compose build to run.
[x] ./.eslintrc.json
[ ] ./.gem_release.yml
- [ ] bundle exec gem bump
- [ ] bundle exec gem release
[x] ./.github
- [x] ./.github/stale.yml
[x] ./.gitignore
[x] ./.rubocop.yml
[x] ./app
- Copied from frontend directory.
[x] ./bin/console
[x] ./bin/rails
[ ] ./bin/rake
- [ ] bin/rake changelog
- [x] bin/rake clean
- [x] bin/rake clobber
- [x] bin/rake console
- [x] bin/rake db:create
- [x] bin/rake db:drop
- [x] bin/rake db:migrate
- [x] bin/rake db:reset
- [x] bin/rake extension:specs
- [x] bin/rake extension:test_app
- [x] bin/rake sandbox
[x] ./bin/sandbox
[x] ./bin/setup
[x] ./CHANGELOG.md
[x] ./config
- Copied from frontend directory.
[x] ./Gemfile
[x] ./Gemfile.lock
[x] ./lib
- Copied from frontend directory.
[x] ./LICENSE
[x] ./Rakefile
[x] ./README.md
[x] ./solidus_frontend.gemspec
[x] ./spec
- Copied from frontend directory.

gsmendoza commented 2 years ago

Thank you @waiting-for-dev for the review and the kind compliment :) I'm listing my TODOs for this below. Let me know I missed anything:

Test on CircleCI - realized only now that I can probably test the repo on my gsmendoza CircleCI account.
Rebuild SolidusLegacyFrontend as a Solidus extension.
Instead of pointing SolidusLegacyFrontend to Solidus, point the gem to Solidus' subprojects instead (excluding SolidusFrontend, of course).
Test if renaming the manifest.js will break production apps depending on SolidusFrontend.
Update Gemfile - Remove :frontend group.
Update README
- Add notice to let new users know that this is not the recommended frontend anymore.
- Rename "Testing" to "Contributing".
Update Gem summary - We could also link to the new recommended starter frontend.

waiting-for-dev commented 2 years ago

Instead of pointing SolidusLegacyFrontend to Solidus, point the gem to Solidus' subprojects instead (excluding SolidusFrontend, of course).

I think you'll only need solidus_core & solidus_api.

Looks good @gsmendoza, thanks!!

gsmendoza commented 2 years ago

@waiting-for-dev I updated the PR based on your feedback. Can you take another look? Thank!

gsmendoza commented 2 years ago

TODOs, per walkthrough with @kennyadsl :

Test if solidus frontend can be added to an app AFTER Solidus has been installed on it (without any frontend).
Test SolidusFrontend against older versions of Solidus.

gsmendoza commented 2 years ago

Hi @kennyadsl . I made the following updates. Appreciate if you can review!

Fix: Remove some non-frontend code from Solidus that I missed in #2 .
Fix: Decouple the Solidus API and Core versions from the frontend version
Fix: Ensure that SolidusFrontend can be installed on an app that already had Solidus installed on it (without a frontend).