search

solidusio / solidus_frontend

BSD 3-Clause "New" or "Revised" License
2 stars 7 forks source link

Add changes from main to v4.0 #40

Closed AlistairNorman closed 1 year ago

AlistairNorman commented 1 year ago

Summary

I'm having an issue with updating solidus_multi_domain to work with Solidus 4. Specs are failing when I try to run specs on solidus v4.0. I'm not sure of the exact cause of the error but it seems to be because solidus_frontend v4.0 is a little bit behind. solidus_frontend v3.4 is up to date with main but it seems like 4.0 didn't get updated.

waiting-for-dev commented 1 year ago

Hey @AlistairNorman, solidus_frontend is no longer meant to be compatible with Solidus v4. As we say in the Readme:

This repository will only accept bug fixes and security patches for the branches that match supported versions of Solidus:

That said, we don't have any problems with merging that if that helps you, but users shouldn't expect support on it neither having CI green for v4 or main branches. We'll happily merge it if this one with #51 fixes CI.

AlistairNorman commented 1 year ago

I can just change the condition in the solidus_multi_domain gemfile that was using this branch and have it use main instead. That might be better in the future since this won't get future updates.