search

solidusio / solidus_gateway

A collection of payment methods for Solidus
https://solidus.io
BSD 3-Clause "New" or "Revised" License
45 stars 61 forks source link

add ffaker to Gemfile #64

Closed ccarruitero closed 7 years ago

ccarruitero commented 7 years ago

Since this commit ffaker isn't a dependency in core and is causing an error in master build.

ccarruitero commented 7 years ago

failed spec, is unrelated to the change.

I saw similar errors in other builds. I think is related to the requests that we are doing to external apis. Maybe we can solve that using vcr, or something similar, to not make the requests all the time.

ccarruitero commented 7 years ago

r? @tvdeyen

swcraig commented 7 years ago

May we merge this?