search

solidusio / solidus_gateway

A collection of payment methods for Solidus
https://solidus.io
BSD 3-Clause "New" or "Revised" License
45 stars 61 forks source link

add common function to append stripe field #66

Closed ccarruitero closed 7 years ago

ccarruitero commented 7 years ago

Move common append functionality to a function

ccarruitero commented 7 years ago

Failed builds in master was because ffaker problem. Now that is solved that problem should be ok. @tvdeyen Can you run the builds again?

tvdeyen commented 7 years ago

You need to rebase with latest master (and force push) otherwise a rebuild would fail again.

ccarruitero commented 7 years ago

@tvdeyen I updated the branch, but seem to be appears an error in other build. I was making tests in local, but I couldn't replicate the error.

I saw similar errors in other pull requests and I think is something related with the external request that we do.

ccarruitero commented 7 years ago

Is just a code improvement. The change only avoid repeting code for append the fields.

tvdeyen commented 7 years ago

As noted on #71 we will stop adding new features or changes into this gem as we want to encourage people to use individual extensions for payment providers instead.

So, please understand that I will reject this change here now.

Thanks for all your contributions lately. This is very much appreciated!