solidusio / solidus_gateway

A collection of payment methods for Solidus
https://solidus.io
BSD 3-Clause "New" or "Revised" License
45 stars 61 forks source link

Remove deprecation warnings #70

Closed achasveachas closed 7 years ago

achasveachas commented 7 years ago

I went through all of the gateways and updated them to remove all the deprecation warnings that used to come up by testing.

As a side effect, I believe the tests run about a minute faster now.

achasveachas commented 7 years ago

Oh well, it looks like the updates are not backwards compatible. The only builds passing are the two on master branch, None of the older versions work :(

tvdeyen commented 7 years ago

Yes. The changes we need to do would require us to release a mayor version of this gem.

We will discuss this on the core meeting today and will come back with a decision if we want to still support this gem or not.

Thanks for your contribution. Sorry for the inconvenience.