search

solidusio / solidus_paypal_braintree

⛔️ [Archived] Use solidus_braintree instead!
https://github.com/solidusio/solidus_braintree
BSD 3-Clause "New" or "Revised" License
37 stars 78 forks source link

solidus-frontend dependency still exists #294

Closed Rtwena closed 3 years ago

Rtwena commented 3 years ago

I'm getting errors because some of the files are trying to decorate solidus-frontend code, even though solidus-frontend is not a dependency for this gem

https://github.com/solidusio/solidus_paypal_braintree/blob/master/app/decorators/controllers/solidus_paypal_braintree/checkout_controller_decorator.rb#L9 https://github.com/solidusio/solidus_paypal_braintree/blob/master/app/decorators/controllers/solidus_paypal_braintree/orders_controller_decorator.rb#L9

Could there be checks to not run this code if the solidus-frontend is not available? 

uninitialized constant Spree::OrdersController excluded from capture: DSN not set
rails aborted!
NameError: uninitialized constant Spree::OrdersController
/usr/share/rvm/gems/ruby-2.5.3/gems/bootsnap-1.3.2/lib/bootsnap/load_path_cache/core_ext/active_support.rb:74:in `block in load_missing_constant'
/usr/share/rvm/gems/ruby-2.5.3/gems/bootsnap-1.3.2/lib/bootsnap/load_path_cache/core_ext/active_support.rb:8:in `without_bootsnap_cache'
/usr/share/rvm/gems/ruby-2.5.3/gems/bootsnap-1.3.2/lib/bootsnap/load_path_cache/core_ext/active_support.rb:74:in `rescue in load_missing_constant'
/usr/share/rvm/gems/ruby-2.5.3/gems/bootsnap-1.3.2/lib/bootsnap/load_path_cache/core_ext/active_support.rb:56:in `load_missing_constant'
/home/richard/workspace/maisonette-backend/vendor/cache/solidus_paypal_braintree-ca2fb042538d/app/decorators/controllers/solidus_paypal_braintree/orders_controller_decorator.rb:9:in `<module:OrdersControllerDecorator>'