solidusio / solidus_paypal_braintree

⛔️ [Archived] Use solidus_braintree instead!
https://github.com/solidusio/solidus_braintree
BSD 3-Clause "New" or "Revised" License
37 stars 78 forks source link

receiptName gets first and last name fields when user has only first name #302

Open Azeem838 opened 2 years ago

Azeem838 commented 2 years ago

When the user only inputs their first name in the address name field then the user's first and last names will get added to the recipientName here.

The issue is that these firstname and lastname methods always return a string and are not checking if a last_name actually exists.

Example: The user enters "John" as their name on the address field. The recipientName will be "John John"

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.