Closed RyanofWoods closed 2 years ago
Hi @DanielePalombo Currently all Spree::Payments that used Venmo in admin show up as "Risky" because no Postal information was given during the transaction(AVS code "I"). I don't see any reference of a specific way to an address in the documentation or the Braintree Venmo tests, so I am not sure what to do about this.
Venmo integration documentation: https://developer.paypal.com/braintree/docs/guides/venmo/server-side#creating-transactions
Braintree Venmo transaction tests: https://github.com/braintree/braintree_ruby/blob/4dca0d777e1c598f10ecdfd9fba8a8c964768ef7/spec/integration/braintree/transaction_spec.rb#L1935
@RyanofWoods did you try to edit the Fraud Management settings?
I'm sure you have already done it.
I have placed an order using the credit card and it has been marked as Risky anyway. It happens because for default the extension provides only the information for the payment without any customer data. So this is normal even for Venmo.
The AVSResult commit can be dropped if we incorporate https://github.com/solidusio/solidus_paypal_braintree/pull/312 into master beforehand and then rebase.
@RyanofWoods can you please update the PR description with a brief explanation of the PR content, thanks!
Thank you very much for your review @kennyadsl. I made the changes to the precompile and README now. I hope the README is clearer 🙂
Integrate Braintree's Venmo according to their documentation - https://developer.paypal.com/braintree/docs/guides/venmo
Before, Venmo was only available as a funding source through PayPal, meaning you're forced to use this if you want/need Venmo, and therefore cannot use vaulting. Now it's using Braintree's Venmo integration, stores can benefit from using vaulting Venmo, without affecting the PayPal integration. As it is also separate from the Credit Card and PayPal integrations it also allows for more frontend customization and other benefits such as:
Due to this integration, the confirm and complete checkout pages now shows what extension payment type has been used (Credit Card, PayPal, ApplePay and Venmo); for Venmo, it also shows what Venmo account was used.
Detailed information on integrating Venmo has been added to the README.md