search

solidusio / solidus_paypal_braintree

⛔️ [Archived] Use solidus_braintree instead!
https://github.com/solidusio/solidus_braintree
BSD 3-Clause "New" or "Revised" License
37 stars 78 forks source link

Fix Rubocop errors #327

Closed RyanofWoods closed 1 year ago

RyanofWoods commented 1 year ago

As linting warnings is included in the test suite, if introducing new rules is not controlled, the suite will keep breaking upon new rules. This is slowing down deploying as well as giving the repository a bad appearance of breaking specs.

RyanofWoods commented 1 year ago

I took inspiration for disabling NewRules by https://github.com/solidusio/solidus_paypal_commerce_platform/commit/fc16fe7575cbbe6ae00b7a81aaff117adab8772f WDYT @elia? I could also introduce the suite changes like you did in another PR if you would like 🙂