search

solidusio / solidus_paypal_braintree

⛔️ [Archived] Use solidus_braintree instead!
https://github.com/solidusio/solidus_braintree
BSD 3-Clause "New" or "Revised" License
37 stars 78 forks source link

Fix broken specs #328

Closed RyanofWoods closed 1 year ago

RyanofWoods commented 1 year ago

Having a broken suite is blocking merging PRs as well as giving the repository a bad reputation, even though the repositories' logic is not broken.

I would be desirable to have different PRs for these commits, however, unfortunately, they cannot be separated, as each commit fixes a spec, and a green suite is needed to merge.

RyanofWoods commented 1 year ago

For https://github.com/solidusio/solidus_paypal_braintree/pull/328/commits/f68d31430dd6a3585b45df02d994f81f571f1e6f I took inspiration for what you did in the PCP extension @elia. Let me know what you think https://github.com/solidusio/solidus_paypal_commerce_platform/commit/fc16fe7575cbbe6ae00b7a81aaff117adab8772f

RyanofWoods commented 1 year ago

Hey @elia 👋 Got any ideas on why the lint-code job is now failing?

The suite passed originally, but then after I removed the TargetRubyVersion from .rubocop.yml, it fails.

I don't understand how it can handle a version of nil for Rails on some jobs, but not on the lint-code one when generating the Gemfile lock 🤔 https://app.circleci.com/pipelines/github/solidusio/solidus_paypal_braintree/422/workflows/56d0ecc3-1b70-417e-9e89-ee3ce5dcbc30

kennyadsl commented 1 year ago

@RyanofWoods please, rebase now 🙂

kennyadsl commented 1 year ago

@RyanofWoods

Hey @elia 👋 Got any ideas on why the lint-code job is now failing?

I see it's passing now!

elia commented 1 year ago

Awesome 🙌