solidusio / solidus_paypal_braintree

⛔️ [Archived] Use solidus_braintree instead!
https://github.com/solidusio/solidus_braintree
BSD 3-Clause "New" or "Revised" License
37 stars 78 forks source link

Update outdated README.md factory example #331

Open RyanofWoods opened 1 year ago

RyanofWoods commented 1 year ago

Summary

These factories were recently moved when making the extension complaint to solidus_dev_support:

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed (~cross them out~ if they are not):

- [ ] I have added automated tests to cover my changes. - [ ] I have attached screenshots to demo visual changes. - [ ] I have opened a PR to update the guides. - [ ] I have updated the README to account for my changes.

RyanofWoods commented 1 year ago

I think it would be good to say that this file moved in the changelog @kennyadsl as it will cause tests to fail for developers.

RyanofWoods commented 1 year ago

Pending - I actually don't think this the way we want users to include extension's factories anymore. Also, this is outdated: https://github.com/solidusio/solidus_paypal_braintree/blame/29136274ecdbe2c554ef26c80074a92567cd7da1/lib/solidus_paypal_braintree/factories.rb

kennyadsl commented 1 year ago

@RyanofWoods you are right, what about fixing it in this same PR?

RyanofWoods commented 1 year ago

Can do @kennyadsl. I will investigate this more this week 🙂