Closed gsmendoza closed 1 year ago
We want to rename the extension namespace to SolidusBraintree so that hopefully we would have an easier time to merge this repo's code to https://github.com/solidusio/solidus_braintree, which will be done in solidusio/solidus_braintree#92.
Resolves solidusio/solidus_braintree#96 .
In my manual testing, I was able to
See https://github.com/gsmendoza/solidus_store/tree/rails-7-0-4--solidus-3-2-5--braintree--renamed for the test app.
BRAINTREE_MERCHANT_ID
BRAINTREE_PUBLIC_KEY
BRAINTREE_PRIVATE_KEY
rails-7-0-4--solidus-3-2-5--braintree--renamed
rails db:setup
rails spree_sample:load
rails server
braintree_credentials
The extension doesn't work with SolidusStarterFrontend. That will be fixed in https://github.com/solidusio/solidus_braintree/issues/91
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed (~cross them out~ if they are not):
I'll close this PR since I'll be reimplementing this in https://github.com/solidusio/solidus_braintree after https://github.com/solidusio/solidus_braintree/issues/92.
Summary
We want to rename the extension namespace to SolidusBraintree so that hopefully we would have an easier time to merge this repo's code to https://github.com/solidusio/solidus_braintree, which will be done in solidusio/solidus_braintree#92.
Resolves solidusio/solidus_braintree#96 .
Testing
In my manual testing, I was able to
See https://github.com/gsmendoza/solidus_store/tree/rails-7-0-4--solidus-3-2-5--braintree--renamed for the test app.
Reproducing the manual test
BRAINTREE_MERCHANT_ID
,BRAINTREE_PUBLIC_KEY
, andBRAINTREE_PRIVATE_KEY
environment variables to your Braintree credentials.rails-7-0-4--solidus-3-2-5--braintree--renamed
branch.rails db:setup
.rails spree_sample:load
.rails server
.braintree_credentials
.Known issues
The extension doesn't work with SolidusStarterFrontend. That will be fixed in https://github.com/solidusio/solidus_braintree/issues/91
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed (~cross them out~ if they are not):