solidusio / solidus_starter_frontend

🎨 Rails-based starter kit for your Solidus storefront.
BSD 3-Clause "New" or "Revised" License
55 stars 37 forks source link

Remove token_order route #274

Closed gsmendoza closed 1 year ago

gsmendoza commented 1 year ago

Dependencies

This PR can be reviewed since it is no longer expecting additional changes. However, it is set to draft mode until https://github.com/solidusio/solidus_starter_frontend/pull/273 is merged.

Goal

As a SolidusStarterFrontend maintainer I want to remove the token_order route So that users of the frontend would have a more minimal set of routes to begin with.

Are there extensions that depend on the token_order_path?

solidus_auth_devise calls the path helper but only when the gem is used with the legacy frontend. SolidusStarterFrontend no longer uses solidus_auth_devise's frontend overrides because SolidusStarterFrontend has already embedded them to its code.

Other than that, there are no other known calls to token_order_path in Solidus extensions. See

How Has This Been Tested?

Both automated and manual testing.

Screenshots (if appropriate):

image

Types of changes

Checklist: