search

solidusio / solidus_starter_frontend

🎨 Rails-based starter kit for your Solidus storefront.
BSD 3-Clause "New" or "Revised" License
55 stars 37 forks source link

Fix CI config on PRs #308

Closed kennyadsl closed 1 year ago

kennyadsl commented 1 year ago

For some reason, CI is passing on master and failing on PRs https://app.circleci.com/pipelines/github/solidusio/solidus_starter_frontend/1814/workflows/1b52f449-2cca-4bd2-9ea0-1e9a71192049.

We should investigate the CI config and fix this problem.

Additional notes

I suspect it has to do with caching bundled gems, but still have no evidence for that.

kennyadsl commented 1 year ago

https://github.com/solidusio/solidus_starter_frontend/pull/309 closes this. It was not an issue with the CI but with the PR itself. But https://github.com/solidusio/solidus_starter_frontend/pull/309 allows us to see tests results in CircleCI so I could spot the issue.