solidusio / solidus_starter_frontend

🎨 Rails-based starter kit for your Solidus storefront.
BSD 3-Clause "New" or "Revised" License
55 stars 37 forks source link

Payment step cleanup #321

Closed elia closed 1 year ago

elia commented 1 year ago

Summary

Removes the two tier radio buttons to select between wallet payment sources and filling in from scratch.

It's predicated under the following assumptions:

This layout and decisions are also informed by multiple real world stores that got their payment step redesigned.

Before

Show original behavior https://user-images.githubusercontent.com/1051/219420532-c91ffe24-ea19-488b-84f4-8ba45145195e.mov image

After

image

https://user-images.githubusercontent.com/1051/219440642-112350bc-1893-459c-b4fd-c8f24aba4e44.mov

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

kennyadsl commented 1 year ago

@elia still not reviewing but... a "before" screenshot would be helpful to quickly navigate what's changing, especially when the description of the PR is empty. 😬

elia commented 1 year ago

@kennyadsl yes 💯 agree, will probably do a short video demonstrating how broken it is