feat: localizing cart review page

solidusio / solidus_starter_frontend

🎨 Rails-based starter kit for your Solidus storefront.

BSD 3-Clause "New" or "Revised" License

55 stars 37 forks source link

feat: localizing cart review page #323

Closed mtatheonly closed 1 year ago

mtatheonly commented 1 year ago

enable localizing shopping cart review page

Summary

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

[x] I have written a thorough PR description.
[x] I have kept my commits small and atomic.
[x] I have used clear, explanatory commit messages.

The following are not always needed:

📖 I have updated the README to account for my changes.
📑 I have documented new code with YARD.
🛣️ I have opened a PR to update the guides.
✅ I have added automated tests to cover my changes.
📸 I have attached screenshots to demo visual changes.

waiting-for-dev commented 1 year ago

Thanks for your contribution, @mtatheonly. I think we should localize all or nothing. However, as this code is copied over to the host application, IIRC we decided not to localize it as users who need it can update the files, and those who don't have a simpler code. cc @kennyadsl, @elia, @gsmendoza

elia commented 1 year ago

@waiting-for-dev It looks like those hardcoded strings were introduced here, there's no mention of avoiding localization, but I'll defer to your and @gsmendoza and @kennyadsl's memory.

I'll send a tentative approval, since the translations are already there, and the resto of the template are all using translations.

kennyadsl commented 1 year ago

I can't recall that we decided to avoid using translations, so going to approve after the squash. But let me know if I am missing something. Thanks a lot for the contribution!

waiting-for-dev commented 1 year ago

Oh, sorry, I was confused. For some reason I thought that we weren't using localization anywhere in the starter frontend.