Turn the product-card partial into a component - Githubissues

solidusio / solidus_starter_frontend

🎨 Rails-based starter kit for your Solidus storefront.

BSD 3-Clause "New" or "Revised" License

55 stars 37 forks source link

Turn the product-card partial into a component #328

Closed elia closed 1 year ago

elia commented 1 year ago

Summary

Only render the currency microdata when the price is present
Keep the cache block in the products grid
Add specs for rendering with/without a taxon

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

[x] I have written a thorough PR description.
[x] I have kept my commits small and atomic.
[x] I have used clear, explanatory commit messages.

The following are not always needed:

📖 I have updated the README to account for my changes.
📑 I have documented new code with YARD.
🛣️ I have opened a PR to update the guides.
✅ I have added automated tests to cover my changes.
📸 I have attached screenshots to demo visual changes.

elia commented 1 year ago

@kennyadsl added a commit removing support for @taxon ✂️