solidusio / solidus_starter_frontend

🎨 Rails-based starter kit for your Solidus storefront.
BSD 3-Clause "New" or "Revised" License
55 stars 37 forks source link

Add payment info partial handling #334

Closed rainerdema closed 1 year ago

rainerdema commented 1 year ago

Summary

Allow each payment method to define how it is displayed on the confirm and thank-you page.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

codecov[bot] commented 1 year ago

Codecov Report

Merging #334 (402f545) into main (d554de2) will decrease coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #334      +/-   ##
==========================================
- Coverage   97.06%   97.05%   -0.01%     
==========================================
  Files         185      190       +5     
  Lines        4494     4484      -10     
==========================================
- Hits         4362     4352      -10     
  Misses        132      132              
Impacted Files Coverage Δ
templates/app/helpers/checkout_helper.rb 100.00% <100.00%> (ø)
templates/app/views/orders/_payment_info.html.erb 100.00% <100.00%> (ø)
...ates/app/views/orders/payment_info/_check.html.erb 100.00% <100.00%> (ø)
...es/app/views/orders/payment_info/_default.html.erb 100.00% <100.00%> (ø)
...es/app/views/orders/payment_info/_gateway.html.erb 100.00% <100.00%> (ø)
templates/spec/helpers/checkout_helper_spec.rb 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more