Track Solidus v3.4 on CI - Githubissues

solidusio / solidus_starter_frontend

🎨 Rails-based starter kit for your Solidus storefront.

Other

58 stars 40 forks source link

Track Solidus v3.4 on CI #336

Closed waiting-for-dev closed 1 year ago

waiting-for-dev commented 1 year ago

Summary

After releasing Solidus v3.4, we need the v3.4 branch here to be tested against that version.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

[x] I have written a thorough PR description.
[x] I have kept my commits small and atomic.
[x] I have used clear, explanatory commit messages.

The following are not always needed:

📖 I have updated the README to account for my changes.
📑 I have documented new code with YARD.
🛣️ I have opened a PR to update the guides.
✅ I have added automated tests to cover my changes.
📸 I have attached screenshots to demo visual changes.

waiting-for-dev commented 1 year ago

Ref https://github.com/solidusio/solidus/issues/4990