solidusio / solidus_starter_frontend

🎨 Rails-based starter kit for your Solidus storefront.
BSD 3-Clause "New" or "Revised" License
55 stars 37 forks source link

Fix factories loading #338

Closed kennyadsl closed 1 year ago

kennyadsl commented 1 year ago

Summary

With Solidus v4.0 we don't have the factories defined in spree/testing_support anymore. Better to fetch them from the proper file that includes all the definitions.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

codecov[bot] commented 1 year ago

Codecov Report

Merging #338 (cb37ed4) into main (e3632ae) will decrease coverage by 0.03%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #338      +/-   ##
==========================================
- Coverage   97.09%   97.06%   -0.03%     
==========================================
  Files         190      190              
  Lines        4505     4469      -36     
==========================================
- Hits         4374     4338      -36     
  Misses        131      131              
Impacted Files Coverage Ξ”
template.rb 84.93% <ΓΈ> (ΓΈ)

... and 4 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more