solidusio / solidus_starter_frontend

🎨 Rails-based starter kit for your Solidus storefront.
Other
58 stars 40 forks source link

Some general ERB cleanup #341

Closed elia closed 1 year ago

elia commented 1 year ago

Summary

I bumped into these small fixes while migrating the JS files to stimulus controllers, using a separate PR so that the migration PRs will have less noise.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

codecov[bot] commented 1 year ago

Codecov Report

Merging #341 (ef472d5) into main (c44af61) will increase coverage by 0.03%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #341      +/-   ##
==========================================
+ Coverage   97.09%   97.12%   +0.03%     
==========================================
  Files         190      190              
  Lines        4505     4490      -15     
==========================================
- Hits         4374     4361      -13     
+ Misses        131      129       -2     
Impacted Files Coverage Ξ”
templates/app/views/products/_products.html.erb 100.00% <100.00%> (ΓΈ)
...mplates/app/views/products/_products_grid.html.erb 100.00% <100.00%> (ΓΈ)
templates/app/views/products/index.html.erb 90.00% <100.00%> (+15.00%) :arrow_up:
templates/spec/system/search_spec.rb 100.00% <100.00%> (ΓΈ)

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more