solidusio / solidus_starter_frontend

🎨 Rails-based starter kit for your Solidus storefront.
BSD 3-Clause "New" or "Revised" License
55 stars 37 forks source link

More JavaScript turned into Stimulus #344

Closed elia closed 1 year ago

elia commented 1 year ago

Summary

This is a simple translation of existing JS into Stimulus with the minimal amount of work needed to make it work. No attempt was made at improving or fixing the overall architecture.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

codecov[bot] commented 1 year ago

Codecov Report

Merging #344 (56dae24) into main (9c27457) will decrease coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #344      +/-   ##
==========================================
- Coverage   97.13%   97.13%   -0.01%     
==========================================
  Files         190      190              
  Lines        4500     4497       -3     
==========================================
- Hits         4371     4368       -3     
  Misses        129      129              
Impacted Files Coverage Δ
templates/app/views/carts/_cart_header.html.erb 100.00% <ø> (ø)
templates/app/views/carts/_cart_item.html.erb 100.00% <ø> (ø)
templates/app/views/carts/show.html.erb 100.00% <100.00%> (ø)
templates/app/views/layouts/_top_bar.html.erb 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more