Remove the deprecated spec helper

solidusio / solidus_starter_frontend

🎨 Rails-based starter kit for your Solidus storefront.

BSD 3-Clause "New" or "Revised" License

55 stars 37 forks source link

Remove the deprecated spec helper #349

Closed kennyadsl closed 1 year ago

kennyadsl commented 1 year ago

Summary

So it is not copied over applications on new installations.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

[ ] I have written a thorough PR description.
[ ] I have kept my commits small and atomic.
[ ] I have used clear, explanatory commit messages.

The following are not always needed:

📖 I have updated the README to account for my changes.
📑 I have documented new code with YARD.
🛣️ I have opened a PR to update the guides.
✅ I have added automated tests to cover my changes.
📸 I have attached screenshots to demo visual changes.

kennyadsl commented 1 year ago

Specs should be fixed with the release of solidus_paypal_commerce_platform v1.0.2, see https://github.com/solidusio/solidus_paypal_commerce_platform/pull/200.

codecov[bot] commented 1 year ago

Codecov Report

Merging #349 (7a40215) into main (df9a4a8) will decrease coverage by 0.02%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #349      +/-   ##
==========================================
- Coverage   97.28%   97.26%   -0.02%     
==========================================
  Files         190      189       -1     
  Lines        4528     4505      -23     
==========================================
- Hits         4405     4382      -23     
  Misses        123      123

see 2 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more