solidusio / solidus_starter_frontend

🎨 Rails-based starter kit for your Solidus storefront.
BSD 3-Clause "New" or "Revised" License
56 stars 37 forks source link

Resolve `chromedriver` issue via CircleCI config and dependency adjustments #352

Closed rainerdema closed 1 year ago

rainerdema commented 1 year ago

Summary

Upgrade of browser-tools in CircleCI config:

Removal of webdrivers gem:

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

codecov[bot] commented 1 year ago

Codecov Report

Merging #352 (5ecd5a6) into main (bbd7dca) will decrease coverage by 0.02%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #352      +/-   ##
==========================================
- Coverage   97.31%   97.30%   -0.02%     
==========================================
  Files         187      187              
  Lines        4511     4488      -23     
==========================================
- Hits         4390     4367      -23     
  Misses        121      121              
Files Coverage Δ
template.rb 84.93% <ø> (-0.21%) :arrow_down:
.../spec/support/solidus_starter_frontend/capybara.rb 68.75% <ø> (-1.84%) :arrow_down:

... and 3 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more