Use a number field for cart item quantity

solidusio / solidus_starter_frontend

🎨 Rails-based starter kit for your Solidus storefront.

BSD 3-Clause "New" or "Revised" License

55 stars 37 forks source link

Summary

Selects for numbers are a bad idea. It is possible for our variants to have a count_on_hand of Infinity (by unchecking the "track inventory" checkbox. On my machine (32G memory), this took about ten minutes to fill up my memory.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

[ ] I have written a thorough PR description.
[ ] I have kept my commits small and atomic.
[ ] I have used clear, explanatory commit messages.

The following are not always needed:

📖 I have updated the README to account for my changes.
📑 I have documented new code with YARD.
🛣️ I have opened a PR to update the guides.
✅ I have added automated tests to cover my changes.
📸 I have attached screenshots to demo visual changes.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.97%. Comparing base (6e2f055) to head (4d4dad0).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #364 +/- ## ========================================== - Coverage 95.99% 95.97% -0.03% ========================================== Files 207 207 Lines 4874 4846 -28 ========================================== - Hits 4679 4651 -28 Misses 195 195 ```

solidusio / solidus_starter_frontend