solidusio / solidus_starter_frontend

🎨 Rails-based starter kit for your Solidus storefront.
BSD 3-Clause "New" or "Revised" License
58 stars 40 forks source link

fix image display issue #369

Closed danielstanojevic closed 3 months ago

danielstanojevic commented 3 months ago

product images (starter frontend homepage) don't display properly because the size property isn't correct. before: Screenshot from 2024-07-29 20-01-27 after: Screenshot from 2024-07-29 20-00-56

Should have corresponding size in config->initializers->spree.rb or use solidus default size For example:

Spree.config do |config|
  # ...
  config.product_image_styles = {
    mini: "48x48>",
    small: "400x400>",
    big: "680x680>",
    product: "680x680>",
    large: "1200x1200>",
    full: "1600x1600>",
    jumbo: "1600x1600>"
  }
end

Summary

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

danielstanojevic commented 3 months ago

rspec passed locally: Screenshot from 2024-07-29 20-18-34

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.99%. Comparing base (f9950a4) to head (b40cf05).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #369 +/- ## ======================================= Coverage 95.99% 95.99% ======================================= Files 207 207 Lines 4874 4874 ======================================= Hits 4679 4679 Misses 195 195 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.